-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always hide controls if video is playing [Android TV] #3537
Conversation
It's fixed for me. Though I've one concern: the speed is not the same as usual, i.e. SEVEN seconds Edit: here, there is no need for another reaction / click, so it's normal that the time is shorter. |
d29e0aa is the commit which increased the delay, I guess for usability reasons (on some TVs maybe 2s is too short to be able to do anything?) |
@B0pol I reduced to 5s the hide time. New debug apk: app-debug.zip |
Sounds like you have lighting-fast reaction. Have you actually used NewPipe on TV? Quickly looking over controls, reading all labels, and pressing the navigation buttons — all of that in under 2 seconds — is impressive feat (especially since infrared TV remotes have additional ~100 ms of lag due to limitatons of IR protocols). Right now method On TV devices If something ( |
Note, that 7 second timeout isn't really expected to be triggered. You are meant to dismiss controls with BACK button after you are done with them. I agree, that media buttons (PLAY,PAUSE,REWIND etc.) should have different treatment. |
Anyway, as soon as something is pressed, the player resets the hiding countdown |
@Stypox the point is — in some circumstances there is no cooldown. When controls are summoned by showControls (such as when playback is paused), they do not disappear. But if you click on something — for example, change aspect ratio — the controls quickly get hidden again. This makes no sense to me. I believe, that controls should stay permanently summoned after playback is paused — to remind user that playback was indeed paused and not just hanged. Resuming from pause via media buttons — including the buttons on headset — should quickly hide controls, because headsets do not have BACK button to quickly dismiss them. I have sent #3547 with those changes. |
@Poomex please test the apk in the original post |
Unfortunately, the issue hasn't been fixed for me. Pressing play on my bluetooth speaker keeps the interface visible until I tap the screen. |
I>I believe, that controls should stay permanently summoned after playback is paused — to remind user that playback was indeed paused and not just hanged. although sometimes showing controls is needed... I disagree with you in saying hiding them don't make sense, hiding player controls is also useful. sometimes a quick pause and play action is needed such as for reading a table or a chart, for comparing two pics or even for taking a screenshot because it keeps the controls out of the way. my suggestion regarding showing controls after pause or hiding them is divided in two parts as fallow: #For phones:
B. when to hide controls after pause: when using double tap to pause gesture. that is:
#For TVs: This unifies the double tap to seek and pause/play gestures behavior related to player controls showing or hiding.. it also gives newPipe a cleaner UI feeling for both TVs and smartphones whenever a quick pause and play action is needed like what I explained above |
@Alexander-- should I close this in favour of #3547? |
Yes, I suggest you do |
What is it?
Description of the changes in your PR
In #2806 a new
safeHideControls
function was added, that would hide controls only if they were opened using a touch gesture. This is obviously never the case when using a tv, so aftersafeHideControls
was used (i.e. after every click on the interface), nothing would happen, preventing controls from ever being hidden. I assume this was added because on a tv it takes some time to press the correct buttons, thus having the ui close while selecting things would have been annoying, so now I made it so thatsafeHideControls
hides controls while the video is playing, too, and otherwise the old behaviour is preserved. Also see #2806 (comment)Fixes the following issue(s)
Testing apk
@Poomex @B0pol @Generator could you test if the usability on TV devices is preserved, even if the ui is hidden when the video is playing?
app-debug.zip
Agreement